Messages in this thread | | | Date | Tue, 29 Sep 2009 16:20:37 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/5] x86, mce: rename finished to valid in struct mce II |
| |
On 09/29/2009 04:04 PM, Andi Kleen wrote: > Hidetoshi Seto wrote: >> Andi Kleen wrote: >>> struct mce is exported to user space. I don't think it's a good idea >>> to rename fields in exported structures like this. That just causes confusion. >> >> I don't know any other real user of this struct than the mcelog and the >> mce test suite. In other words, I expected that you (Huang and Andi) are >> only users who may be confused by this kind of change. > > Also I should add there are other consumers of /dev/mcelog, not just > mcelog/mce-inject. >
Details?
-hpa
| |