lkml.org 
[lkml]   [2009]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...)
    On 09/29, Christian Borntraeger wrote:
    >
    >
    > The network code must not be called with disabled interrupts but
    > sys_setsid holds the tasklist_lock with spinlock_irq while calling
    > the connector. We can safely move proc_sid_connector from
    > __set_special_pids to sys_setsid.
    >
    > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
    >
    > ---
    > kernel/exit.c | 4 +---
    > kernel/sys.c | 2 ++
    > 2 files changed, 3 insertions(+), 3 deletions(-)
    >
    > Index: linux-2.6/kernel/exit.c
    > ===================================================================
    > --- linux-2.6.orig/kernel/exit.c
    > +++ linux-2.6/kernel/exit.c
    > @@ -359,10 +359,8 @@ void __set_special_pids(struct pid *pid)
    > {
    > struct task_struct *curr = current->group_leader;
    >
    > - if (task_session(curr) != pid) {
    > + if (task_session(curr) != pid)
    > change_pid(curr, PIDTYPE_SID, pid);
    > - proc_sid_connector(curr);
    > - }
    >
    > if (task_pgrp(curr) != pid)
    > change_pid(curr, PIDTYPE_PGID, pid);
    > Index: linux-2.6/kernel/sys.c
    > ===================================================================
    > --- linux-2.6.orig/kernel/sys.c
    > +++ linux-2.6/kernel/sys.c
    > @@ -1110,6 +1110,8 @@ SYSCALL_DEFINE0(setsid)
    > err = session;
    > out:
    > write_unlock_irq(&tasklist_lock);
    > + if (err > 0)
    > + proc_sid_connector(sid);
    > return err;
    > }

    Acked-by: Oleg Nesterov <oleg@redhat.com>

    I'd suggest you to resend this patch to Andrew. Unless you know
    another way to push it into Linus's tree ;)

    Perhaps it makes sense to update the changelog, it should mention
    the issues with daemonize().

    Oleg.



    \
     
     \ /
      Last update: 2009-09-29 18:35    [W:0.030 / U:0.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site