Messages in this thread | | | Subject | Re: [PATCH] drivers/scsi/libsas: Use SAM_GOOD | From | James Bottomley <> | Date | Tue, 29 Sep 2009 14:12:26 +0000 |
| |
On Tue, 2009-09-29 at 08:00 +0200, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > The field stat->stat should be compared to SAM_GOOD, not SAM_STAT_GOOD, as > done elsewhere in the same function. Both constants have the same value.
Actually, I'd like to see us go the other way. Use the standard SCSI defined SAM_STAT macros in libsas instead of its hand rolled equivalents. This would mean modifying aic94xx/aic94xx_task.c and libsas.h as well.
Thanks,
James
| |