lkml.org 
[lkml]   [2009]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Updated: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl7225b.c
From
Date
On Mon, 2009-09-28 at 15:10 -0700, Bruce Jones wrote:
> Cleanup the printk's in this driver to use KERN_foo log
> levels.
> + printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
> this_board->name, iobase);
> if (!request_region(iobase, iorange, "acl7225b")) {
> - printk("I/O port conflict\n");
> + printk(KERN_CONT "I/O port conflict\n");

This should not be KERN_CONT but KERN_INFO or KERN_ERR
and should probably have a "comedi%d:" leader.

Maybe:
printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n");

cheers, Joe



\
 
 \ /
  Last update: 2009-09-29 00:21    [W:0.044 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site