lkml.org 
[lkml]   [2009]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: No more bits in vm_area_struct's vm_flags.
    On Mon, 28 Sep 2009 14:37:48 +1000
    Nigel Cunningham <ncunningham@crca.org.au> wrote:

    > Hi.
    >
    > KAMEZAWA Hiroyuki wrote:
    > > Then, Nigel, you have 2 choices I think.
    > >
    > > (1) don't merge if vm_hints is set or (2) pass vm_hints to all
    > > __merge() functions.
    > >
    > > One of above will be accesptable for stakeholders... I personally
    > > like (1) but just trying (2) may be accepted.
    > >
    > > What I dislike is making vm_flags to be long long ;)
    >
    > Okay. I've gone for option 1 for now. Here's what I
    > currently have (compile testing as I write)...
    >
    >
    >
    > vm_flags in struct vm_area_struct is full. Move some of the less commonly
    > used flags to a new variable so that other flags that need to be in vm_flags
    > (because, for example, they need to be in variables that are passed around)
    > can be added.
    >
    > Signed-off-by: Nigel Cunningham <nigel@tuxonice.net>

    Seems good to me.

    Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    But
    > + if (vma->vm_hints)
    > + return 0;
    > return 1;

    Maybe adding a comment (or more detailed patch description) is necessary.

    Regards,
    -Kame

    > }
    >
    > --
    > 1.6.3.3
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >



    \
     
     \ /
      Last update: 2009-09-28 06:57    [W:0.024 / U:147.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site