lkml.org 
[lkml]   [2009]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ARM: Remove unused CONFIG reference DEBUG_S3C_PORT
From
Date
Hello Robert,

On Sat, 2009-09-26 at 10:03 -0400, Robert P. J. Day wrote:
> On Sat, 26 Sep 2009, Jaswinder Singh Rajput wrote:
>
> >
> > Remove unused CONFIG reference DEBUG_S3C_PORT from defconfig
> >
> > Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > Cc: Byungho Min <bhmin@samsung.com>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > Cc: Russell King <rmk+lkml@arm.linux.org.uk>
> > ---
> > arch/arm/configs/s5pc100_defconfig | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/configs/s5pc100_defconfig b/arch/arm/configs/s5pc100_defconfig
> > index b0d7d3d..94edde5 100644
> > --- a/arch/arm/configs/s5pc100_defconfig
> > +++ b/arch/arm/configs/s5pc100_defconfig
> > @@ -859,7 +859,6 @@ CONFIG_DEBUG_ERRORS=y
> > # CONFIG_DEBUG_STACK_USAGE is not set
> > CONFIG_DEBUG_LL=y
> > # CONFIG_DEBUG_ICEDCC is not set
> > -CONFIG_DEBUG_S3C_PORT=y
> > CONFIG_DEBUG_S3C_UART=0
>
> no, there is no point removing redundant entries from any of the
> defconfig files -- those files will eventually be rebuilt
> automatically at some point.
>

Who will build defconfig for old architectures like h3600_defconfig and
others.

If we are removing unused CONFIG from Kconfig then there is no point of
leaving those entries in defconfigs after all git grep keep those
entries and lead to confusions sooner or later. Yeah, for this case
where we have only entry in defconfig you sounds good but let
maintainers will decide it :-)

Thanks,
--
JSR





\
 
 \ /
  Last update: 2009-09-26 17:25    [W:0.034 / U:14.896 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site