Messages in this thread | | | From | "Andrey Panin" <> | Date | Fri, 25 Sep 2009 12:13:45 +0400 | Subject | Re: [PATCH 4/5 v2] tracing/filters: Provide basic regex support |
| |
On 267, 09 24, 2009 at 09:49:34PM +0200, Frederic Weisbecker wrote: > This patch provides basic support for regular expressions in filters.
> +/* Basic regex callbacks */ > +static int regex_match_full(char *str, struct regex *r, int len) > +{ > + if (strncmp(str, r->pattern, len) == 0) > + return 1; > + return 0; > +} > + > +static int regex_match_front(char *str, struct regex *r, int len) > +{ > + if (strncmp(str, r->pattern, len) == 0) > + return 1; > + return 0; > +}
These two functions are identical, what's the reason to keep them separate ? And why not simply return strncmp(str, r->pattern, len) == 0 ?
| |