Messages in this thread | | | Date | Thu, 24 Sep 2009 21:20:02 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf tools: Dont use openat() |
| |
* Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Ingo Molnar a ?crit : > > * Eric Dumazet <eric.dumazet@gmail.com> wrote: > > > >> Hi Ingo > >> > >> Here is a patch for perf. > > > > Applied, thanks Eric! > > > >> BTW, use of openat() is a nuisance, since many machines have old glibc > >> (RHEL 4 Update 5 -> glibc-2.3.4-2.36 on my dev machine for example) > > > > We can certainly remove that reliance - wanna send a patch for it? > > Here it is > > Thanks > > [PATCH] perf tools: Dont use openat() > > openat() is still a young glibc facility, better to not use it > in a non performance critical program (perf list) > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > --- > tools/perf/util/parse-events.c | 49 ++++++++++++------------------- > 1 files changed, 20 insertions(+), 29 deletions(-)
Applied, thanks Eric! I think it's also significant enough to be pushed to 2.6.32.
Ingo
| |