Messages in this thread Patch in this message | | | Date | Thu, 24 Sep 2009 15:05:59 +0200 | From | Eric Dumazet <> | Subject | [PATCH] perf tools: fix buffer allocation |
| |
Hi Ingo
Here is a patch for perf.
BTW, use of openat() is a nuisance, since many machines have old glibc (RHEL 4 Update 5 -> glibc-2.3.4-2.36 on my dev machine for example)
Thanks
[PATCH] perf tools: fix buffer allocation
"perf top" cores dump on my dev machine, if run from a directory where vmlinux is present.
*** glibc detected *** malloc(): memory corruption: 0x085670d0 ***
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- tools/perf/util/module.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/module.c b/tools/perf/util/module.c index 8f81622..0d8c85d 100644 --- a/tools/perf/util/module.c +++ b/tools/perf/util/module.c @@ -423,7 +423,7 @@ static int mod_dso__load_module_paths(struct mod_dso *self) len += strlen(uts.release); len += strlen("/modules.dep"); - dpath = calloc(1, len); + dpath = calloc(1, len + 1); if (dpath == NULL) return err;
| |