Messages in this thread | | | Date | Wed, 23 Sep 2009 16:43:09 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] Revert "kmod: fix race in usermodehelper code" |
| |
On Thu, 24 Sep 2009, Sebastian Andrzej Siewior wrote: > > The pach is wrong IMHO. UMH_WAIT_EXEC is called with VFORK what ensures > that the child finishes prior returing back to the parent. No race. The patch > makes it even worse because it does the thing it claims not do: > - It calls ->complete() on UMH_WAIT_EXEC > - the complete() callback may de-allocated subinfo
Yeah, I think you're right. That commit is bogus. Thanks for noticing.
Linus
| |