lkml.org 
[lkml]   [2009]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [origin tree boot hang] [PATCH] Revert "early_printk: Allowmorethan one early console"

* Jason Wessel <jason.wessel@windriver.com> wrote:

> Ingo Molnar wrote:
> > * Ingo Molnar <mingo@elte.hu> wrote:
> >
> >
> >
> >> The commit point to which the attached config and bootlog belongs is:
> >>
> >> 2.6.31-07863-gb64ada6
> >>
> >> Reverting:
> >>
> >> c953094: early_printk: Allow more than one early console
> >>
> >> solves it.
> >>
> >
> > btw., the boot options are:
> >
> > Command line: root=/dev/sda6 earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 debug
> > initcall_debug apic=verbose sysrq_always_enabled ignore_loglevel
> > selinux=0 nmi_watchdog=0 panic=1 3
> >
> >
>
> AH HA!
>
> earlyprintk=serial,ttyS0,115200
>
> You are invoking the same device twice which is why you are having
> infinite recursion. It was not obvious to me why the earlyprintk code
> would allow "serial" or "ttyS", but perhaps we need to protect for
> that?
>
> Your boot line should be:
>
> earlyprintk=serial,115200
>
> OR
>
> earlyprintk=ttyS0,115200

ah, indeed!

> The line you had there before would have been the equivalent of doing:
>
> earlyprintk=ttyS0,ttyS0,115200
>
> Given this, do we still need to execute the revert your revert? Or
> perhaps do we need to add some protection?

I have such lines on other boxes too. I'd suggest to add protection if
it's not too ugly - the typoed line worked and was pretty natural to do,
and the failure mode is nasty enough.

Ingo


\
 
 \ /
  Last update: 2009-09-23 23:43    [W:0.127 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site