Messages in this thread | | | Subject | RE: [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs | Date | Tue, 22 Sep 2009 08:53:19 +0100 | From | "Hennerich, Michael" <> |
| |
>From: Jiri Kosina >Sent: Tuesday, September 22, 2009 9:33 AM > >On Mon, 21 Sep 2009, Dmitry Torokhov wrote: > >> > + if (event & KP_INT) { >> > + adp5520_read(dev->master, KP_INT_STAT_1, ®_val_low); >> > + adp5520_read(dev->master, KP_INT_STAT_2, ®_val_high); >> > + >> > + keymask = (reg_val_high << 8) | reg_val_low; >> > + /* Read twice to clear */ >> > + adp5520_read(dev->master, KP_INT_STAT_1, ®_val_low); >> > + adp5520_read(dev->master, KP_INT_STAT_2, ®_val_high); >> > + keymask |= (reg_val_high << 8) | reg_val_low; >> > + adp5520_keys_report_event(dev, keymask, 1); >> > + } >> > + >> > + if (event & KR_INT) { >> >> Why do you check the same condition twice? > >It actually doesn't seem to be the same condition (KP_INT vs. KR_INT), but >it's difficult to say, as these constants are apparently added in some >other patch I have no idea about.
KP Key-Press versus Key-Release
>And the same for other constants used in the code ... the patch seems to >be quite incomplete.
The missing constants are in include/linux/mfd/adp5520.h
This file was sent in a different patch, adding support for the Multi Function Device Core (drivers/mfd/adp5520.c)
-Michael
------------------------------------------------------------------ ********* Analog Devices GmbH ** ***** Systems Engineering ** ** Wilhelm-Wagenfeld-Strasse 6 ** ***** D-80807 Munich ********* Germany Registergericht München HRB 40368, Geschäftsführer: Thomas Wessel, William A. Martin, Margaret K. Seif
> >-- >Jiri Kosina >SUSE Labs, Novell Inc.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |