Messages in this thread | | | Date | Tue, 22 Sep 2009 14:29:37 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 3/5] checkpatch: add a blacklist |
| |
Daniel Walker wrote: > There are times when maintainers intentially don't follow the coding > style. When that happens it means some errors need to be ignored, so > that other errors can be focused on. > > To handle that I added a blacklist to checkpatch. The blacklist holds the > file names and errors which are ignored. The output is modified to > remove the errors from the list and not to count them. > > When the blacklist kicks in there is a note that does list how many > errors got removed and that it was due to a blacklist entry. There is > also a new option "--noblacklist" that allows the errors to be added > back as it was without the blacklist. >
So, for this piece of code:
TRACE_EVENT(...
TP_fast_assign( __entry->foo = bar( xxx ); ), )
checkpatch won't report the spaces inside bar()? If so, I don't like this patch.
Could you just teach checkpatch to recognize those macros used in TRACE_EVENT(), if those coding-style "errors" bother you so much that you can't put up with them?
| |