lkml.org 
[lkml]   [2009]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v5 RFC PATCH 0/7]: cpuidle/x86/POWER (REDESIGN): Cleanup idle power management code in x86, cleanup drivers/cpuidle/cpuidle.c and introduce cpuidle to POWER.
    * Peter Zijlstra <a.p.zijlstra@chello.nl> [2009-09-22 09:25:59]:

    >
    >
    > Much better :-)
    >
    >
    > But I'm puzzled by all the per-cpu-ish-ness of the stuff. Why would you
    > need to register things on a per-cpu basis?
    >
    > Also:
    >
    >
    > + list_for_each(pos, &per_cpu(cpuidle_devices_list, cpu)) {
    > + temp_dev = container_of(pos, struct cpuidle_device,
    > + percpu_list[cpu]);
    > + if (dev == temp_dev) {
    > + list_del(&temp_dev->percpu_list[cpu]);
    > + cpuidle_remove_state_sysfs(temp_dev);
    > + }
    > + }
    >
    > Looks buggy, either you want to break out of the loop on dev ==
    > temp_dev, or you want to use list_for_each_safe().
    >
    >
    >

    Hi Peter,

    There were a couple of buggy issues, which i have cleaned up for the
    next iteration.

    * As you pointed out above, the loop is buggy.
    * Also, the percpu_list[NR_CPUS] which i am defining inside
    struct cpuidle_device is wrong. It does not need to be an
    array.

    Thanks for the quick turnaround
    arun


    \
     
     \ /
      Last update: 2009-09-22 10:59    [W:0.022 / U:1.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site