| Date | Mon, 21 Sep 2009 09:43:12 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] move sh_flctl's probe function to .devinit.text |
| |
Hello,
On Sat, Sep 19, 2009 at 04:09:54PM -0700, David Woodhouse wrote: > On Sat, 2009-07-11 at 13:52 -0700, Uwe Kleine-König wrote: > > A pointer to flctl_probe is passed to the core via > > platform_driver_register and so the function must not disappear when the > > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > > unbinding and binding a device to the driver via sysfs will result in an > > oops as does a device being registered late. > > > > An alternative to this patch is using platform_driver_probe instead of > > platform_driver_register plus removing the pointer to the probe function > > from the struct platform_driver. > > ... which is what you did for orion_nand, so let's do that for sh_flctl > too. > > http://git.infradead.org/mtd-2.6.git/commitdiff/894572a3635 Ah, you already did it, fine. If you want (and still can) you can add my Acked-by:
Best regards, thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|