Messages in this thread Patch in this message | | | From | "Metzger, Markus T" <> | Date | Mon, 21 Sep 2009 08:12:12 +0100 | Subject | RE: [PATCH] perf_counter/powerpc: Fix compilation after perf_counter_overflow change |
| |
>-----Original Message----- >From: Paul Mackerras [mailto:paulus@samba.org] >Sent: Monday, September 21, 2009 8:45 AM
>Markus, please take care in future to mention it in the changelog if >your patches touch definitions used by other architectures. If you >could go so far as to use grep a bit more and fix up other >architectures' callsites for the things you're changing, that would be >very much appreciated. Thanks.
I'm sorry I missed that.
There's one more place in arch/sparc/. The below patch should fix it, but I have no means to test it.
Index: b/arch/sparc/kernel/perf_counter.c =================================================================== --- a/arch/sparc/kernel/perf_counter.c +++ b/arch/sparc/kernel/perf_counter.c @@ -493,7 +493,6 @@ static int __kprobes perf_counter_nmi_ha regs = args->regs; - data.regs = regs; data.addr = 0; cpuc = &__get_cpu_var(cpu_hw_counters); @@ -513,7 +512,7 @@ static int __kprobes perf_counter_nmi_ha if (!sparc_perf_counter_set_period(counter, hwc, idx)) continue; - if (perf_counter_overflow(counter, 1, &data)) + if (perf_counter_overflow(counter, 1, &data, regs)) sparc_pmu_disable_counter(hwc, idx); }
thanks and regards, markus.
--------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen Germany Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr. VAT Registration No.: DE129385895 Citibank Frankfurt (BLZ 502 109 00) 600119052 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
| |