Messages in this thread | | | Subject | Re: [RFC][PATCH 3/8] sched: update the cpu_power sum during load-balance | From | Peter Zijlstra <> | Date | Wed, 02 Sep 2009 13:25:06 +0200 |
| |
On Wed, 2009-09-02 at 16:47 +0530, Gautham R Shenoy wrote: > > + if (local_group) { > > balance_cpu = group_first_cpu(group); > > + if (balance_cpu == this_cpu) > > + update_sched_power(sd); > > + } > > I guess the intention of this check is to ensure that the cpu_power for > the group of sd is updated only by a specific member of the group and > that would ideally be the first member of the group. > > Thus, this check has more to do with this_cpu being the > group_first_cpu() than this_cpu being the balance_cpu. Correct ?
Right, so the load-balancer walks the sd tree in the fashion that only the first cpu of the domain goes up a level. So I made that cpu also aggregate the new cpu-power.
| |