lkml.org 
[lkml]   [2009]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/8] writeback: check for registered bdi in flusher add and inode dirty
    Date
    Also a debugging aid. We want to catch dirty inodes being added to
    backing devices that don't do writeback.

    Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
    ---
    fs/fs-writeback.c | 7 +++++++
    include/linux/backing-dev.h | 1 +
    mm/backing-dev.c | 6 ++++++
    3 files changed, 14 insertions(+), 0 deletions(-)

    diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
    index bf5519a..ea97a82 100644
    --- a/fs/fs-writeback.c
    +++ b/fs/fs-writeback.c
    @@ -1005,6 +1005,13 @@ void __mark_inode_dirty(struct inode *inode, int flags)
    */
    if (!was_dirty) {
    struct bdi_writeback *wb = &inode_to_bdi(inode)->wb;
    + struct backing_dev_info *bdi = wb->bdi;
    +
    + if (bdi_cap_writeback_dirty(bdi) &&
    + !test_bit(BDI_registered, &bdi->state)) {
    + WARN_ON(1);
    + printk("bdi-%s not registered\n", bdi->name);
    + }

    inode->dirtied_when = jiffies;
    list_move(&inode->i_list, &wb->b_dirty);
    diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
    index 801d29c..836ede9 100644
    --- a/include/linux/backing-dev.h
    +++ b/include/linux/backing-dev.h
    @@ -29,6 +29,7 @@ enum bdi_state {
    BDI_wb_alloc, /* Default embedded wb allocated */
    BDI_async_congested, /* The async (write) queue is getting full */
    BDI_sync_congested, /* The sync queue is getting full */
    + BDI_registered, /* bdi_register() was done */
    BDI_unused, /* Available bits start here */
    };

    diff --git a/mm/backing-dev.c b/mm/backing-dev.c
    index 77c8974..e7f98d3 100644
    --- a/mm/backing-dev.c
    +++ b/mm/backing-dev.c
    @@ -464,6 +464,11 @@ void static bdi_add_default_flusher_task(struct backing_dev_info *bdi)
    if (!bdi_cap_writeback_dirty(bdi))
    return;

    + if (WARN_ON(!test_bit(BDI_registered, &bdi->state))) {
    + printk("bdi %p/%s is not registered!\n", bdi, bdi->name);
    + return;
    + }
    +
    /*
    * Check with the helper whether to proceed adding a task. Will only
    * abort if we two or more simultanous calls to
    @@ -527,6 +532,7 @@ int bdi_register(struct backing_dev_info *bdi, struct device *parent,
    }

    bdi_debug_register(bdi, dev_name(dev));
    + set_bit(BDI_registered, &bdi->state);
    exit:
    return ret;
    }
    --
    1.6.4.1.207.g68ea


    \
     
     \ /
      Last update: 2009-09-02 10:49    [W:0.028 / U:30.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site