lkml.org 
[lkml]   [2009]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwmon: Driver for Texas Instruments amc6821 chip
On Mon, 31 Aug 2009 22:24:50 +0200
tomaz.mertelj@guest.arnes.si wrote:

> I have crafted a hwmon driver for Texas Instruments amc6821 SMB-bus 2-
> channel temperature sensor, pwm controller. This is my first linux project
> so some corrections will be necessary.
>

The driver looks saneish to me, but...

- The attachment uses \r\n line termination and caused me quite a bit
of trouble before I worked out what was going on.

- The changelog is missing your Signed-off-by:. Please read up on
this in Documentation/SubmittingPatches.

- The driver needs lots and lots of trivial coding-style fixes.
Please take a look at some similar drivers and also use the
scripts/checkpatch.pl tool.

checkpatch says:

total: 153 errors, 110 warnings, 874 lines checked

which must be some sort of record ;)

Also, some C functions have needless `\' line continuations in them.


All pretty simple stuff. Please take a look at all that and then resend?

Thanks.



\
 
 \ /
  Last update: 2009-09-03 01:59    [W:0.045 / U:2.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site