lkml.org 
[lkml]   [2009]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] thermal: sysfs-api.txt - document passive attribute for thermal zones
Hi!

> > > We should not involve any platform specific stuff in this
> > > documentation. how about "Attribute is only present for zones in which
> > > the passive cooling policy is not supported by native thermal driver"
> > [...]
> > > > -If the processor is listed in _PSL method, and the fan is listed in
> > > > _AL0 -method, the sys I/F structure will be built like this:
> > > > +If the processor is listed in _PSL method, the fan is listed in _AL0
> > > > +method, and the zone has a _PSV method, the sys I/F structure will
> > > > be +built like this:
> > >
> > > For an ACPI thermal zone, supporting passive cooling means that both
> > > _PSL and _PSV are available.
> > > so I don't think we need to change this. :)
> >
> > OK. Updated patch below.
> >
> >
> > From: Frans Pop <elendil@planet.nl>
> > Subject: thermal: sysfs-api.txt - document passive attribute for thermal zones
> >
> > Signed-off-by: Frans Pop <elendil@planet.nl>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Sujith Thomas <sujith.thomas@intel.com>
> > Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> >
> Acked-by: Zhang Rui <rui.zhang@intel.com>
>
> thanks,
> rui
> > diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
> > index 895337f..a87dc27 100644
> > --- a/Documentation/thermal/sysfs-api.txt
> > +++ b/Documentation/thermal/sysfs-api.txt
> > @@ -199,6 +199,15 @@ cdev[0-*]_trip_point
> > point.
> > RO, Optional
> >
> > +passive
> > + Attribute is only present for zones in which the passive cooling
> > + policy is not supported by native thermal driver. Default is zero
> > + and can be set to a temperature (in millidegrees) to enable a
> > + passive trip point for the zone. Activation is done by polling
> > + with an interval of 1 second.
> > + Unit: millidegrees Celsius
> > + RW, Optional
> > +

So '0=disabled'? Better say that, because throttling at 0C would be
useless in most of the world.

Are values below zero supported? Maybe -28000mC should mean
'disabled'? :-).

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-09-02 22:05    [W:0.059 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site