lkml.org 
[lkml]   [2009]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ARM: copy_page.S: take into account the size of the cache line
On Wed, Sep 02, 2009 at 07:11:53PM +0300, Kirill A. Shutemov wrote:
> ENTRY(copy_page)
> stmfd sp!, {r4, lr} @ 2
> PLD( pld [r1, #0] )
> - PLD( pld [r1, #32] )
> + PLD( pld [r1, #L1_CACHE_BYTES] )
> mov r2, #COPY_COUNT @ 1
> ldmia r1!, {r3, r4, ip, lr} @ 4+1
> -1: PLD( pld [r1, #64] )
> - PLD( pld [r1, #96] )
> -2: stmia r0!, {r3, r4, ip, lr} @ 4
> - ldmia r1!, {r3, r4, ip, lr} @ 4+1
> - stmia r0!, {r3, r4, ip, lr} @ 4
> - ldmia r1!, {r3, r4, ip, lr} @ 4+1
> +1: PLD( pld [r1, #(2*L1_CACHE_BYTES)])
> + PLD( pld [r1, #(3*L1_CACHE_BYTES)])

I really hate unnecessary parens - please remove them, and put a space
each side of the '*'.

> +2:
> + .rept (2 * (L1_CACHE_BYTES) / 16 - 1)

Parens are not required around L1_CACHE_BYTES either.

Other than that, patch is fine.


\
 
 \ /
  Last update: 2009-09-02 15:27    [W:0.140 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site