Messages in this thread Patch in this message | | | Date | Sat, 19 Sep 2009 09:13:43 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH] drivers/usb: Correct use of ! and & |
| |
From: Julia Lawall <julia@diku.dk>
Correct priority problem in the use of ! and &.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression E; constant C; @@ - !E & C + !(E & C) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/usb/usb-skeleton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff -u -p a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c --- a/drivers/usb/usb-skeleton.c +++ b/drivers/usb/usb-skeleton.c @@ -358,7 +358,7 @@ retry: rv = skel_do_read_io(dev, count); if (rv < 0) goto exit; - else if (!file->f_flags & O_NONBLOCK) + else if (!(file->f_flags & O_NONBLOCK)) goto retry; rv = -EAGAIN; } @@ -411,7 +411,7 @@ static ssize_t skel_write(struct file *f * limit the number of URBs in flight to stop a user from using up all * RAM */ - if (!file->f_flags & O_NONBLOCK) { + if (!(file->f_flags & O_NONBLOCK)) { if (down_interruptible(&dev->limit_sem)) { retval = -ERESTARTSYS; goto exit;
| |