Messages in this thread | | | Subject | Re: [patch] x86, apic: use logical flat on intel with <= 8 logical cpus | From | Daniel Walker <> | Date | Fri, 18 Sep 2009 19:19:50 -0700 |
| |
On Fri, 2009-09-18 at 19:05 -0700, Suresh Siddha wrote: > + switch (boot_cpu_data.x86_vendor) { > + case X86_VENDOR_INTEL: > + if (num_processors > 8) > + apic = &apic_physflat; > + break; > + case X86_VENDOR_AMD: > + if (max_physical_apicid >= 8) > + apic = &apic_physflat; > + }
There are a couple of checkpatch issues in this patch .. Could you run it through and fix the errors that show up.. One is that you need 1 less tab for the code inside the switch statement .. You have another switch statement in apic.c that needs similar attention .
Daniel
| |