lkml.org 
[lkml]   [2009]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch] x86, apic: use logical flat on intel with <= 8 logical cpus
    From
    Date
    On Fri, 2009-09-18 at 19:05 -0700, Suresh Siddha wrote:
    > + switch (boot_cpu_data.x86_vendor) {
    > + case X86_VENDOR_INTEL:
    > + if (num_processors > 8)
    > + apic = &apic_physflat;
    > + break;
    > + case X86_VENDOR_AMD:
    > + if (max_physical_apicid >= 8)
    > + apic = &apic_physflat;
    > + }

    There are a couple of checkpatch issues in this patch .. Could you run
    it through and fix the errors that show up.. One is that you need 1 less
    tab for the code inside the switch statement .. You have another switch
    statement in apic.c that needs similar attention .

    Daniel



    \
     
     \ /
      Last update: 2009-09-19 04:23    [W:0.020 / U:31.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site