lkml.org 
[lkml]   [2009]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] serial: bfin_5xx: remove useless gpio handling with hard flow control
    Date
    From: Sonic Zhang <sonic.zhang@analog.com>

    For UARTs that have dedicated hardware flow control support, there will be
    no gpios to request/free as they are part of the normal peripheral pins.

    Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    ---
    drivers/serial/bfin_5xx.c | 16 +---------------
    1 files changed, 1 insertions(+), 15 deletions(-)

    diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
    index b4a7650..1b7fd62 100644
    --- a/drivers/serial/bfin_5xx.c
    +++ b/drivers/serial/bfin_5xx.c
    @@ -742,15 +742,6 @@ static int bfin_serial_startup(struct uart_port *port)
    Status interrupt.\n");
    }

    - if (uart->cts_pin >= 0) {
    - gpio_request(uart->cts_pin, DRIVER_NAME);
    - gpio_direction_output(uart->cts_pin, 1);
    - }
    - if (uart->rts_pin >= 0) {
    - gpio_request(uart->rts_pin, DRIVER_NAME);
    - gpio_direction_output(uart->rts_pin, 0);
    - }
    -
    /* CTS RTS PINs are negative assertive. */
    UART_PUT_MCR(uart, ACTS);
    UART_SET_IER(uart, EDSSI);
    @@ -797,10 +788,6 @@ static void bfin_serial_shutdown(struct uart_port *port)
    gpio_free(uart->rts_pin);
    #endif
    #ifdef CONFIG_SERIAL_BFIN_HARD_CTSRTS
    - if (uart->cts_pin >= 0)
    - gpio_free(uart->cts_pin);
    - if (uart->rts_pin >= 0)
    - gpio_free(uart->rts_pin);
    if (UART_GET_IER(uart) && EDSSI)
    free_irq(uart->status_irq, uart);
    #endif
    @@ -1405,8 +1392,7 @@ static int bfin_serial_remove(struct platform_device *dev)
    continue;
    uart_remove_one_port(&bfin_serial_reg, &bfin_serial_ports[i].port);
    bfin_serial_ports[i].port.dev = NULL;
    -#if defined(CONFIG_SERIAL_BFIN_CTSRTS) || \
    - defined(CONFIG_SERIAL_BFIN_HARD_CTSRTS)
    +#if defined(CONFIG_SERIAL_BFIN_CTSRTS)
    gpio_free(bfin_serial_ports[i].cts_pin);
    gpio_free(bfin_serial_ports[i].rts_pin);
    #endif
    --
    1.6.5.rc1


    \
     
     \ /
      Last update: 2009-09-17 23:55    [W:3.006 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site