lkml.org 
[lkml]   [2009]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [stable] [patch 44/45] PCI: Unhide the SMBus on the Compaq Evo D510 USDT
On Thu, Sep 17, 2009 at 03:09:17PM +0200, Jean Delvare wrote:
> On Thu, 17 Sep 2009 04:38:53 -0700, Greg KH wrote:
> > On Thu, Sep 17, 2009 at 09:58:23AM +0200, Jean Delvare wrote:
> > > Hi Greg,
> > >
> > > On Wed, 16 Sep 2009 15:36:57 -0700, Greg KH wrote:
> > > > 2.6.31-stable review patch. If anyone has any objections, please let us know.
> > > >
> > > > ------------------
> > > > From: Jean Delvare <khali@linux-fr.org>
> > > >
> > > > commit 6b5096e4d4496e185cd1ada5d1b8e1d941c805ed upstream.
> > > >
> > > > One more form factor for Compaq Evo D510, which needs the same quirk
> > > > as the other form factors. Apparently there's no hardware monitoring
> > > > chip on that one, but SPD EEPROMs, so it's still worth unhiding the
> > > > SMBus.
> > >
> > > FWIW, this one doesn't strike me as being needed in -stable. While it
> > > should be safe (otherwise it wouldn't have gone upstream in the first
> > > place), it hardly fulfills -stable's requirement that "it must fix a
> > > real bug that bothers people". There's no hardware monitoring chip on
> > > the SMBus on this machine, and people can easily live without detailed
> > > memory module information.
> > >
> > > So it's up to you, but I won't cry if you drop this patch from -stable.
> >
> > Heh, you were the one that originally cc:ed the patch to
> > stable@kernel.org, so I figured you wanted it in.
>
> That would be the other me then. Because the first me just double
> checked that he hadn't Cc'd stable@kernel.org on this one patch ;)

My appologies, you are correct, I had gotten this off of the linux-pci
list and copied it to my stable queue as a potential patch for it.

Anyway, it's easier for me if it stays :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-09-17 15:31    [from the cache]
©2003-2011 Jasper Spaans