Messages in this thread | | | Date | Thu, 17 Sep 2009 13:36:22 +0400 | From | Alexey Kuznetsov <> | Subject | Re: [PATCH 2/2] ipv4: make do_ip_setsockopt for IP_MULTICAST_IF support ip_mreq struct |
| |
Hello!
On Thu, Sep 17, 2009 at 05:19:16PM +0800, Danny Feng wrote: > In fact, current implemetation supports: > > struct ip_mreqn mreqn; > setsockopt(socket, IPPROTO_IP, IP_MULTICAST_IF, &mreqn, sizeof(mreqn)); > > Then why not support mreq?
Because support of ip_mreqn makes sense (it user interface index) and support of ip_mreq, which does not contain interface index, does not. "Polymorphic" IP_MULTICAST_IF was a stupid mistake (mine), which should not grow like a tumor.
Ack to patch #1, nack to #2.
Alexey
| |