lkml.org 
[lkml]   [2009]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] sparc: Clean up linker script using new linker script macros.
From
From: Tim Abbott <tabbott@ksplice.com>
Date: Wed, 16 Sep 2009 14:03:48 -0400 (EDT)

> On Wed, 16 Sep 2009, David Miller wrote:
>
>> It's hard for me to ACK this because it's not a straight nop
>> transformation, which we could at least presume would function
>> properly if the macros were implemented correctly.
>
> Would it help if I were to split the patch into first rearranging the code
> to look like the macros and then applying the macros, so that you can see
> more easily exactly what is changing?

No, it wouldn't :-) The issue is that I can't just say from
reading the patch that it will absolutely work.

But I'm willing to take the risk and we can revert if testing
shows it breaks things, so:

Acked-by: David S. Miller <davem@davemloft.net>


\
 
 \ /
  Last update: 2009-09-17 00:35    [W:0.050 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site