Messages in this thread | | | Date | Wed, 16 Sep 2009 15:00:40 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 05/11] Assign bdi in super_block |
| |
On Wed, Sep 16 2009, Jan Kara wrote: > On Tue 15-09-09 20:16:51, Jens Axboe wrote: > > We do this automatically in get_sb_bdev() from the set_bdev_super() > > callback. Filesystems that have their own private backing_dev_info > > must assign that in ->fill_super(). > > > > Note that ->s_bdi assignment is required for proper writeback! > > > > Acked-by: Christoph Hellwig <hch@infradead.org> > > Signed-off-by: Jens Axboe <jens.axboe@oracle.com> > > --- > > fs/btrfs/disk-io.c | 1 + > > fs/fuse/inode.c | 2 ++ > > fs/super.c | 6 ++++++ > > fs/sync.c | 9 ++++++++- > > fs/ubifs/super.c | 1 + > > include/linux/fs.h | 1 + > > 6 files changed, 19 insertions(+), 1 deletions(-) > I think we agreed that NFS needs to assign it's private BDI to sb->s_bdi, > didn't we? From Tronds comment, that should be enough.
Oops indeed, added that one-liner now.
-- Jens Axboe
| |