Messages in this thread | | | Subject | Re: [PATCH tracing/kprobes 3/6] ftrace: Fix trace_remove_event_call() to lock trace_event_mutex | From | Steven Rostedt <> | Date | Tue, 15 Sep 2009 23:17:30 -0400 |
| |
On Mon, 2009-09-14 at 16:49 -0400, Masami Hiramatsu wrote:
> > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 38e82a5..a3d6bad 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -1055,6 +1055,9 @@ static void remove_subsystem_dir(const char *name) > } > } > > +/* > + * Must be called under locking both of event_mutex and trace_event_mutex. > + */ > static void __trace_remove_event_call(struct ftrace_event_call *call) > { > ftrace_event_enable_disable(call, 0); > @@ -1071,7 +1074,9 @@ static void __trace_remove_event_call(struct ftrace_event_call *call) > void trace_remove_event_call(struct ftrace_event_call *call)
Is this from a previous patch set, because I can't find this in either my tree or tip/master.
-- Steve
> { > mutex_lock(&event_mutex); > + down_write(&trace_event_mutex); > __trace_remove_event_call(call); > + up_write(&trace_event_mutex); > mutex_unlock(&event_mutex); > } > > >
| |