[lkml]   [2009]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC][PATCH] LED driver for Intel NAS SS4200 series
On Tue, 2009-09-15 at 14:52 -0700, Dave Hansen wrote:
> On Tue, 2009-09-15 at 22:38 +0100, Richard Purdie wrote:
> > At a quick review this looks good. One question: These LEDs appear to be
> > attached to generic GPIOs on a southbridge that is probably in other
> > devices? If so, how do we know they're connected to LEDs? Do we need to
> > add some further check of what kind of device we're running on?
> Good question. I assumed that the PCI ids were a sufficient enough
> check. But, you're right, those PCI ids look like they're for all ICH7
> boards.
> Any suggestions on what kinds of checks we might add? This thing acts
> like a pretty generic normal PC. Do any of the other LED drivers have a
> similar problem?

Yes. In this case can we check for a set of DMI IDs? The clevo mail
driver has an example of that...



Richard Purdie
Intel Open Source Technology Centre

 \ /
  Last update: 2009-09-16 00:05    [W:0.038 / U:30.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site