lkml.org 
[lkml]   [2009]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] trace: Convert the power tracer into an event tracer
On Tue, 15 Sep 2009 11:43:16 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:

> Arjan van de Ven wrote:
> >>From f591a0f126263733d606838a5d113b9807b12c84 Mon Sep 17 00:00:00
> >>2001
> > From: Arjan van de Ven <arjan@linux.intel.com>
> > Date: Sat, 12 Sep 2009 07:53:03 +0200
> > Subject: [PATCH] trace: Convert the power tracer into an event
> > tracer
> >
> > This patch converts the existing power tracer into an event tracer,
> > so that power events (C states and frequency changes) can be tracked
> > via "perf".
> >
> > This also removes the perl script that was used to demo the tracer;
> > its functionality is being replaced entirely with timechart.
> >
>
> And Documentation/power.txt needs update, or just remove it?

remove it; will do
>
> > Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
>
> ...
>
> > diff --git a/kernel/trace/power-traces.c
> > b/kernel/trace/power-traces.c new file mode 100644
> > index 0000000..cb4fc51
> > --- /dev/null
> > +++ b/kernel/trace/power-traces.c
>
> This file is not necessarily needed.
>
> You can just add definition of CREATE_TRACE_POINTS in process.c.

hmm it seems existing style to do this in kernel/trace/ though

> > +
> > +EXPORT_TRACEPOINT_SYMBOL_GPL(power_start);
> > +
>
> I think it's power_frequency that needs to be exported?

very valid point, will fix.

thank you for reviewing the patch; I will send an updated patch out
asap.


--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2009-09-15 06:15    [W:0.053 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site