[lkml]   [2009]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] arm: remove unused code in delay.S

    > >> > Because then you get it whenever you configure for V4 as the lowest
    > >> > denominator CPU, which leads to the buggy behaviour on better CPUs.
    > >> > It's far better to leave it as is and just accept that the old CPUs
    > >> > will have longer than necessary delays.  If people really really
    > >> > care (and there's likely to only be a small minority of them now)
    > >> > changing the '0' to a '1' is a very simple change for them to carry
    > >> > in their local tree.  Unlike getting the right unrolling etc.
    > >>
    > >> Well, they can also 'git revert' this patch. If somebody really cares
    > >> I think they should shout now and provide a better patch, otherwise
    > >> this one should be merged.
    > >
    > > On the other hand, having the code there as it currently stands is not
    > > harmful in any way, so leaving it there is just as easy.
    > It makes the code less understandable. I'm not sure about linux's
    > practices, but an #if 0 generally means somebody is being lazy.

    Not in this case, as you was explained to you. You may want to add
    explaining comment above #if 0....

    (cesky, pictures)
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-09-15 12:41    [W:0.022 / U:15.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site