Messages in this thread | | | Subject | Re: [RFC][v6][PATCH 0/9] clone_with_pids() syscall | From | Peter Zijlstra <> | Date | Mon, 14 Sep 2009 09:14:11 +0200 |
| |
On Sat, 2009-09-12 at 10:19 -0700, Sukadev Bhattiprolu wrote: > Peter Zijlstra [peterz@infradead.org] wrote: > | On Fri, 2009-09-11 at 09:47 -0700, Sukadev Bhattiprolu wrote: > | > | Also, if you're passing a struct, why not put nr_pids in there, and > | > | replace clone_pid_struct with a simple array? That would give us > | > | > | > | struct clone_struct { > | > | u64 flags; > | > | u64 child_stack; > | > | u32 child_tid; > | > | u32 parent_tid; > > BTW, these two tids are __user pointers that kernel copies data into. > They should be u64 to avoid conversions in architecture specific code ?
Yeah, just take the idea not the details from these posts ;-)
| |