lkml.org 
[lkml]   [2009]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/6] tracing: have TRACE_EVENT macro use __flags to not shadow parameter
    From: Steven Rostedt <srostedt@redhat.com>

    The generated functions of TRACE_EVENT uses "flags" in one of the
    sub macros which shadows a parameter in the outside macro.

    Simple fix is to make the submacro use __flags instead.

    Discovered by sparse.

    Reported-by: Jaswinder Singh Rajput <jaswinder@kernel.org>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    include/trace/ftrace.h | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
    index fa8ce03..72a3b43 100644
    --- a/include/trace/ftrace.h
    +++ b/include/trace/ftrace.h
    @@ -239,9 +239,9 @@ ftrace_format_##call(struct ftrace_event_call *unused, \
    #undef __print_flags
    #define __print_flags(flag, delim, flag_array...) \
    ({ \
    - static const struct trace_print_flags flags[] = \
    + static const struct trace_print_flags __flags[] = \
    { flag_array, { -1, NULL }}; \
    - ftrace_print_flags_seq(p, delim, flag, flags); \
    + ftrace_print_flags_seq(p, delim, flag, __flags); \
    })

    #undef __print_symbolic
    --
    1.6.3.3
    --


    \
     
     \ /
      Last update: 2009-09-14 18:37    [W:0.037 / U:60.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site