Messages in this thread | | | Date | Mon, 14 Sep 2009 07:50:47 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] cleanup legacy console_print function |
| |
On Fri, 11 Sep 2009, Anirban Sinha wrote: > > - console_print(text); \ > - console_print("\n"); \ > + printk(KERN_EMERG "%s", text); \ > + printk(KERN_EMERG "\n"); \
Just clean it up to be
printk(KERN_EMERG "%s\n", text);
instead while at it.
> #define TRACE_CHR(chr) \ > { \ > if(dtlk_trace) \ > - console_print(chr); \ > + printk(KERN_EMERG "%c", chr); \
That can't be right. The translation is to use "%s", not "%c".
Linus
| |