lkml.org 
[lkml]   [2009]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/10] x86: Convert BUG() to use unreachable()
    On 09/11/2009 08:55 AM, David Daney wrote:
    >
    > Perhaps, although with a pre-GCC-4.5 compiler, it would end up adding
    > the endless loop code to BUG() sites for configurations where the user
    > has explicitly stated their preference for the code to be as small as
    > possible (by turning off CONFIG_BUG).
    >
    > If that is acceptable, I will prepare another revision of the patch set.
    >

    The thing is that without the loop, the compiler will generate the
    fall-through case code, which may add more code than the loop removes.

    -hpa

    --
    H. Peter Anvin, Intel Open Source Technology Center
    I work for Intel. I don't speak on their behalf.



    \
     
     \ /
      Last update: 2009-09-13 22:15    [W:4.040 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site