lkml.org 
[lkml]   [2009]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Epic regression in throughput since v2.6.23

* Serge Belyshev <belyshev@depni.sinp.msu.ru> wrote:

> Note that the disabling NEW_FAIR_SLEEPERS doesn't fix 3%
> regression from v2.6.23, but instead makes "make -j4" runtime
> another 2% worse (27.05 -> 27.72).

ok - thanks for the numbers, will have a look.

> ---
> tools/perf/builtin-stat.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)

> + // quick ugly hack: if a "--" appears in the command, treat is as
> + // a delimiter and use remaining part as a "cleanup command",
> + // not affecting performance counters.
> + cleanup = cleanup_argc = 0;
> + for (j = 1; j < (argc-1); j ++) {
> + if (!strcmp (argv[j], "--")) {
> + cleanup = j + 1;
> + cleanup_argc = argc - j - 1;
> + argv[j] = NULL;
> + argc = j;
> + }
> + }

Nice feature!

How about doing it a bit cleaner, as '--repeat-prepare' and
'--repeat-cleanup' options, to allow both pre-repeat and post-repeat
cleanup ops to be done outside of the measured period?

Ingo


\
 
 \ /
  Last update: 2009-09-13 17:51    [W:0.279 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site