lkml.org 
[lkml]   [2009]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [16/21] HWPOISON: The high level memory error handler in the VM v7
On Fri, Sep 11, 2009 at 01:58:04PM -0700, Daniel Walker wrote:
> On Fri, 2009-09-11 at 21:33 +0200, Andi Kleen wrote:
> > > The rest of your patches are totally clean, except this one .. It has
> > > some warning, but one error in the second ifdef block above ..
> >
> > That's intentional, fixing it would require a bare , on a single line
> > which would be far uglier what is there today. I refuse to make code
> > ugly just to work around checkpatch.pl
>
>
> Like the following is clean, and I don't see why it would work. Although
> I only compile tested it.

That would turn a simple two liner change into a monstrosity of patch.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2009-09-12 00:01    [from the cache]
©2003-2011 Jasper Spaans