lkml.org 
[lkml]   [2009]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [16/21] HWPOISON: The high level memory error handler in the VM v7
From
Date
On Fri, 2009-09-11 at 21:33 +0200, Andi Kleen wrote:
> > The rest of your patches are totally clean, except this one .. It has
> > some warning, but one error in the second ifdef block above ..
>
> That's intentional, fixing it would require a bare , on a single line
> which would be far uglier what is there today. I refuse to make code
> ugly just to work around checkpatch.pl
>
> -Andi

Here's the error,

ERROR: space required after that ',' (ctx:ExV)
#1086: FILE: fs/proc/meminfo.c:148:
+ ,atomic_long_read(&mce_bad_pages) << (PAGE_SHIFT - 10)
^

I think it just wants a space after the comma .. Couldn't you also break
up these printk's so the two ifdef'ed parts are combined into a single
printk that just adds on to the prior print out?

Daniel





\
 
 \ /
  Last update: 2009-09-11 21:41    [W:0.042 / U:0.088 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site