Messages in this thread | | | Date | Fri, 11 Sep 2009 09:28:04 -0700 | From | Greg KH <> | Subject | Re: [PATCH] TPM: Fixup pubek sysfs file |
| |
On Fri, Sep 04, 2009 at 02:03:25PM -0700, Andrew Morton wrote: > On Thu, 03 Sep 2009 22:02:24 -0700 > Roland Dreier <rdreier@cisco.com> wrote: > > > > > > Algorithm: 00 00 00 01 > > > Encscheme: 00 03 > > > Sigscheme: 00 01 > > > Parameters: 00 00 08 00 00 00 00 02 00 00 00 00 > > > Modulus length: 256 > > > > No argument that this fix is an improvement, but what happened to the > > "one value per file" rule for sysfs?? > > We goofed. This one snuck through. > > It's one of the reasons why I recommend that people cite examples of > the sysfs/procfs output in changelogs. These things are part of the > kernel ABI and once they go in we cannot change them so we have to get > them right first time.
Also, I try to ask for a Documentation/ABI/ update for every new sysfs file that is added. That will show this kind of thing quite easily.
thanks,
greg k-h
| |