Messages in this thread | | | Date | Fri, 11 Sep 2009 17:43:51 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 3/3] tracing: add latency format to function_graph tracer |
| |
On Fri, Sep 11, 2009 at 06:38:10PM +0300, Török Edwin wrote: > On 2009-09-11 18:18, Frederic Weisbecker wrote: > > On Fri, Sep 11, 2009 at 11:11:56AM -0400, Steven Rostedt wrote: > > > >> On Fri, 2009-09-11 at 16:55 +0200, Frederic Weisbecker wrote: > >> > >> > >>> Oh, BTW, what would you think about addding the current->lock_depth > >>> in the latency format? That may help debug the bkl... > >>> > >> Hmm, that would require adding another field for all traces. I don't > >> want to increase the size of an entry unneeded. BTW, this is for all > >> entries (even events). > >> > > > > > > Right... > > > > > > > >> Ug! I just noticed that tgid was added to struct trace_entry, with the > >> only user as the user stack entry. This should be in the user stack > >> field not something that goes into every event! > >> > >> I guess I need to fix that too. > >> > > Indeed tgid should be part of struct userstack_entry, and set in > ftrace_trace_userstack. > Do you want to me to write up a patch for that, or have you already > fixed it? > > Best regards, > --Edwin
No, please do.
Thanks!
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |