lkml.org 
[lkml]   [2009]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3] tracing/profile: add ref count for registering profile events
    From
    Date
    On Fri, 2009-09-11 at 09:54 -0400, Steven Rostedt wrote:

    > +#ifdef MODULE
    > +# define event_trace_up_ref() \
    > + do { \
    > + if (!try_module_get(THIS_MODULE)) { \
    > + atomic_dec(&event_call->profile_count); \
    > + return -ENOENT; \
    > + } \
    > + } while (0)
    > +# define event_trace_down_ref() module_put(THIS_MODULE)
    > +#else
    > +# define event_trace_up_ref() do { } while (0)
    > +# define event_trace_down_ref() do { } while (0)
    > +#endif

    That's like truely gruesomely ugly.

    At the very least write it like:

    int event_trace_up_ref(struct ftrace_event_call *call)
    {
    if (!try_module_get(THIS_MODULE)) {
    atomic_dev(&call->profile_count);
    return -ENOENT;
    }
    return 0;
    }



    \
     
     \ /
      Last update: 2009-09-11 16:07    [W:0.022 / U:1.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site