lkml.org 
[lkml]   [2009]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: iwlagn: order 2 page allocation failures
Date
On Thursday 10 September 2009, reinette chatre wrote:
> From: Reinette Chatre <reinette.chatre@intel.com>
> Date: Wed, 9 Sep 2009 15:41:00 -0700
> Subject: [PATCH] iwlwifi: reduce noise when skb allocation fails

Looks good to me (from a user's perspective).
IIUC the first message is now only displayed if IWL debugging is
explicitly enabled, and the second only if there really is danger of it
affecting data transfer and has been made more informative too.

It seems to me that, with debugging enabled, the "Failed to allocate SKB
buffer." message may get repeated, but I guess that's minor.

One nitpick. As you've made the message into sentences, "Only %u free
buffers remaining" should IMO also end with a period.

Thanks,
FJP


\
 
 \ /
  Last update: 2009-09-10 20:45    [W:0.094 / U:11.380 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site