Messages in this thread | | | Subject | Re: [PATCH v2] tracing: Clean up trace.h | From | Steven Rostedt <> | Date | Thu, 10 Sep 2009 09:34:24 -0400 |
| |
On Thu, 2009-09-10 at 10:25 +0800, Li Zefan wrote: > 于 2009年09月10日 10:17, Steven Rostedt 写道: > > On Thu, 2009-09-10 at 09:34 +0800, Li Zefan wrote: > >> - remove some dead code > >> - remove @stats from struct tracer > >> - move DEFINE_COMPARISON_PRED() and DEFINE_EQUALITY_PRED() > >> to kernel/trace/trace_events_filter.c > >> > > > > Actually, Li if you don't mind, I'm going to break this up into separate > > patches. Each of the above "topics" really should be a separate patch. > > It makes bisecting and such nicer if for some strange reason this patch > > became the cause. > > > > Actually it does more than I described: > > - indent some lines > - fix a typo in comment > - remove trace_field_cont > - remove tracer_switch_ops > - remove @stats from struct tracer > - move 2 macros to trace_events_filter.c > > I'm not sure it worths breaking into several patches, since each of them > is trivial. > > But I won't mind if you break this up, or if you want me to do > this.
Yeah I already broke it up and sent it out. Some could go together, but I did not like moving code mixed with other cleanups.
Thanks,
-- Steve
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |