lkml.org 
[lkml]   [2009]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: page allocator regression on nommu
Date
Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> This looks to be a bug in nommu do_mmap_pgoff() error handling. I
> guess we shouldn't call __put_nommu_region() if add_nommu_region()
> hasn't been called?

We should to make sure the region gets cleaned up properly. However, it will
go wrong if do_mmap_shared_file() or do_mmap_private() fail. We should
perhaps call add_nommu_region() before doing the "set up the mapping" chunk -
we hold the region semaphore, so it shouldn't hurt anyone if we then have to
remove it again.

David


\
 
 \ /
  Last update: 2009-09-01 15:39    [W:0.079 / U:1.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site