Messages in this thread | | | From | David Howells <> | Subject | Re: page allocator regression on nommu | Date | Tue, 01 Sep 2009 14:35:47 +0100 |
| |
Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> This looks to be a bug in nommu do_mmap_pgoff() error handling. I > guess we shouldn't call __put_nommu_region() if add_nommu_region() > hasn't been called?
We should to make sure the region gets cleaned up properly. However, it will go wrong if do_mmap_shared_file() or do_mmap_private() fail. We should perhaps call add_nommu_region() before doing the "set up the mapping" chunk - we hold the region semaphore, so it shouldn't hurt anyone if we then have to remove it again.
David
| |