Messages in this thread Patch in this message | | | Date | Sun, 9 Aug 2009 10:45:42 GMT | From | tip-bot for Bartlomiej Zolnierkiewicz <> | Subject | [tip:irq/core] irq: Remove superfluous NULL pointer check in check_irq_resend() |
| |
Commit-ID: c36ba80ea01d0aecb652c26799a912e760ce8981 Gitweb: http://git.kernel.org/tip/c36ba80ea01d0aecb652c26799a912e760ce8981 Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> AuthorDate: Thu, 6 Aug 2009 21:46:03 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Sun, 9 Aug 2009 12:44:29 +0200
irq: Remove superfluous NULL pointer check in check_irq_resend()
This takes care of the following entry from Dan's list:
kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'
Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Eugene Teo <eteo@redhat.com> Cc: Julia Lawall <julia@diku.dk> LKML-Reference: <200908062146.03638.bzolnier@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- kernel/irq/resend.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/resend.c b/kernel/irq/resend.c index 89c7117..090c376 100644 --- a/kernel/irq/resend.c +++ b/kernel/irq/resend.c @@ -70,8 +70,7 @@ void check_irq_resend(struct irq_desc *desc, unsigned int irq) if ((status & (IRQ_LEVEL | IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) { desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY; - if (!desc->chip || !desc->chip->retrigger || - !desc->chip->retrigger(irq)) { + if (!desc->chip->retrigger || !desc->chip->retrigger(irq)) { #ifdef CONFIG_HARDIRQS_SW_RESEND /* Set it pending and activate the softirq: */ set_bit(irq, irqs_resend);
| |