Messages in this thread | | | Date | Sun, 9 Aug 2009 11:34:43 -0700 | From | Josh Triplett <> | Subject | Re: [PATCH] x86: Simplify calls to cpuid by using + for in/out constraints |
| |
On Sun, Aug 09, 2009 at 10:19:13AM -0700, H. Peter Anvin wrote: > I would prefer to not apply this patch unless there is a good reason. > The existing code isn't broken, and any time we change an asm() > statement we risk triggering bugs in some obscure gcc version.
Fair enough.
> It isn't, of course, that the proposed change is wrong, but simply that > it is an unnecessary change, and since it involves asm() statements I > would like to reject it for churn reduction reasons. Especially so > since it is "build-tested only".
Given the risk of "bugs in some obscure gcc version", it doesn't seem like running it or even comparing for identical code would validate anything more than the correctness of the gcc version currently in use.
- Josh triplett
| |