[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] chrdev: implement __[un]register_chrdev()
    On Fri, Aug 07, 2009 at 11:34:52AM +0900, Tejun Heo wrote:
    > Hello, Greg.
    > Greg KH wrote:
    > >> For now, it looks like adding the __ prefixed versions seems to be the
    > >> proper solution. It's strange to provide the helper interface only
    > >> for full minor acquisitions anyway. Let's do naming cleanup later.
    > >> How does that sound?
    > >
    > > Well, what's the odds that I can get you to do cleanup now? :)
    > I'd be happy to but whether cleaning it up would be benefitial or not
    > is a bit unclear. We have 214 users of [un]register_chrdev_region()
    > and 118 users of [un]register_chrdev(). So, renaming the latter to,
    > say, create/destroy_chrdev() and make it take @baseminor and
    > @nr_minors should do it but I'm not quite sure whether it would worth
    > touching all those files. Maybe it's better left as a mess like the
    > page allocation functions?

    Yeah, I guess it's easier to leave it alone for now. If I ever get
    bored, I'll work on cleaning them up :)


    greg k-h

     \ /
      Last update: 2009-08-07 06:09    [W:0.031 / U:3.868 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site