lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 4/7] ia64: implement crashkernel=auto
    Amerigo Wang schrieb:
    >
    > +#ifdef CONFIG_KEXEC_AUTO_RESERVE
    > +#ifdef KEXEC_AUTO_RESERVED_SIZE
    > +#undef KEXEC_AUTO_RESERVED_SIZE
    > +#endif
    > +#define KEXEC_AUTO_RESERVED_SIZE (1ULL<<28) /* 256M */
    > +#include <asm-generic/kexec.h>
    > +#endif
    > +
    > extern struct kimage *ia64_kimage;

    IMO that's way too small for practial use on IA64 systems.

    For SLES11, which is based on Linux 2.6.28 IIRC, we use following memory
    size values in the YaST2 kdump module which configures the crashkernel
    parameter (this is YCP syntax, but I think everybody understands it):

    > // bnc #446480 - Fine-tune kdump memory proposal
    > if ((Arch::ia64()) && (total_memory >= 1024))
    > {
    > integer total_memory_gigabyte = total_memory/1024;
    > if ((total_memory_gigabyte >= 1) && (total_memory_gigabyte <12))
    > alocated_memory = "256";
    > else if ((total_memory_gigabyte >= 12) && (total_memory_gigabyte <128))
    > alocated_memory = "512";
    > else if ((total_memory_gigabyte >= 128) && (total_memory_gigabyte <256))
    > alocated_memory = "768";
    > else if ((total_memory_gigabyte >= 256) && (total_memory_gigabyte <378))
    > alocated_memory = "1024";
    > else if ((total_memory_gigabyte >= 378) && (total_memory_gigabyte <512))
    > alocated_memory = "1536";
    > else if ((total_memory_gigabyte >= 512) && (total_memory_gigabyte <768))
    > alocated_memory = "2048";
    > else if (total_memory_gigabyte >= 768)
    > alocated_memory = "3072";
    > }

    I got that assumtions from SGI (and they are known to have large IA64
    systems) and I think the values were tested.

    But IMO it doesn't make sense to put such policy decisions in the
    kernel. I see no advantage for that. The average user doesn't have to
    write crashkernel parameters, they use the values that the distribution
    ships. Or do you think that an average user knows what a UUID of a file
    system is just to specify the correct root partition?


    Regards,
    Bernhard



    \
     
     \ /
      Last update: 2009-08-07 21:19    [W:8.588 / U:1.732 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site