lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch] mISDN: fix reversed if in st_own_ctrl()
The current code probably returns -EINVAL a lot.  Otherwise it would oops.

Compile tested only. Found by smatch (http://repo.or.cz/w/smatch.git).

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>

--- orig/drivers/isdn/mISDN/stack.c 2009-07-17 13:34:57.000000000 +0300
+++ new/drivers/isdn/mISDN/stack.c 2009-07-17 13:35:32.000000000 +0300
@@ -364,7 +364,7 @@
static int
st_own_ctrl(struct mISDNchannel *ch, u_int cmd, void *arg)
{
- if (!ch->st || ch->st->layer1)
+ if (!ch->st || !ch->st->layer1)
return -EINVAL;
return ch->st->layer1->ctrl(ch->st->layer1, cmd, arg);
}

\
 
 \ /
  Last update: 2009-08-07 14:15    [W:0.027 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site